srowen commented on a change in pull request #20793: [WIP][SPARK-23643] Shrinking the buffer in hashSeed up to size of the seed parameter URL: https://github.com/apache/spark/pull/20793#discussion_r255303170
########## File path: sql/core/src/test/resources/sql-tests/results/group-by-ordinal.sql.out ########## @@ -141,12 +141,12 @@ from -- !query 13 schema struct<a:int,rand(0):double,sum(b):bigint> -- !query 13 output -1 0.4048454303385226 2 -1 0.8446490682263027 1 -2 0.5871875724155838 1 -2 0.8865128837019473 2 -3 0.742083829230211 1 -3 0.9179913208300406 2 +1 0.5234194256885571 2 Review comment: Same comment here, but, I suppose we have to assert the exact output given that this is an exact-match test. This is OK. In that case I think it's all the more reasonable to fix the random tests above. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
