maryannxue commented on issue #23759: [SPARK-26840][SQL] Avoid cost-based join reorder in presence of join hints URL: https://github.com/apache/spark/pull/23759#issuecomment-462459426 Sorry, @dongjoon-hyun, I did not look carefully when I merged your PR. I thought you were to replace every occurrence of "case Join(..., hint) if hint == JoinHint.NONE" with "case Join(..., JoinHint.NONE)" which makes sense to me, but it turned out you had changed other logic too. Is there any specific reason you would have to revert the changes I made in "ExtractInnerJoins"? I'll update this PR with an extra test.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
