maryannxue commented on issue #23759: [SPARK-26840][SQL] Avoid cost-based join reorder in presence of join hints URL: https://github.com/apache/spark/pull/23759#issuecomment-462842097 @dongjoon-hyun: > I reviewed again as you suggested. I did not suggest you review it again. I suggested you understand the logic first. Thank you anyway for reviewing it! BTW, I don't totally agree with you on "don't mix the bug fix PR and simple style improvement PR". Ppl can always clean up a few places related to the issue in their PRs, like removing unused imports, correcting styles, refining code comments, etc. Plus, I don't think those two lines of so-called aesthetic changes would be worth another PR (that's going to waste everybody's time). I think we could together make the Spark community more efficient and more constructive if we can focus on important things rather than tell ppl to revert changes that are nice to have.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
