mgaido91 commented on issue #23731: [SPARK-26572][SQL] fix aggregate codegen result evaluation URL: https://github.com/apache/spark/pull/23731#issuecomment-462665785 Thanks for your comment @rednaxelafx , huge +1 on everything you just said. > @mgaido91 are you sure aggregate is the only one that produces unevaluated result expressions? @cloud-fan if it is not the only one, I think we have to fix the others too, but I don't think there are. `ProjectExec` is fine as mentioned by @rednaxelafx and I can't think of other plans which can generate non-deterministic expressions (there may be, but in this moment none comes to my mind).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
