mgaido91 commented on issue #23731: [SPARK-26572][SQL] fix aggregate codegen result evaluation URL: https://github.com/apache/spark/pull/23731#issuecomment-462694006 @rednaxelafx I am +1 too on @kiszk suggestion, but I don't really get why you feel so strong about having them only in `ProjectExec`: honestly, I am not a big fan of the idea, because in case whole-stage code generation fails (we still have some problems not yet addressed, for which we need codegen IR), then we might introduce a significant performance overhead by having an additional `ProjectExec`. Maybe I am missing something, though. Thanks.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
