viirya commented on issue #23731: [SPARK-26572][SQL] fix aggregate codegen 
result evaluation
URL: https://github.com/apache/spark/pull/23731#issuecomment-462696802
 
 
   > @viirya I am not sure what you mean in your last comment. You are saying 
that you are against evaluating the variables in aggregate, but then you are 
saying that you agree with @rednaxelafx 's fix which does that.
   
   The previous fix forces evaluating ALL variables in aggregate. I meant that 
is against whole-stage codegen optimization.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to