viirya commented on issue #23731: [SPARK-26572][SQL] fix aggregate codegen result evaluation URL: https://github.com/apache/spark/pull/23731#issuecomment-462698316 > That's why logical optimizations in Catalyst would treat `Aggregate.aggregateExpression` basically the same way as `Project.projectList` and push expression down to it, e.g. in `CollapseProject`'s `case p @ Project(_, agg: Aggregate) =>` case. I meant for non deterministic expressions, I think the basic rule is not to push down them, as it might change original semantics. So I'm little surprised we do pushing down it to aggregate.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
