peter-toth commented on issue #23731: [SPARK-26572][SQL] fix aggregate codegen 
result evaluation
URL: https://github.com/apache/spark/pull/23731#issuecomment-462917851
 
 
   Thank you all for the comments and suggestions.
   I pushed a commit with the changes except for the change in 
`doProduceWithoutKeys()` as `resultVars` are force evaluated there and changing 
the evaluation to non-deterministic only would be an optimization, not a bugfix.
   Also I didn't change `ProjectExec`, let me know if these 2 should be 
incorporated in this PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to