peter-toth commented on issue #23731: [SPARK-26572][SQL] fix aggregate codegen 
result evaluation
URL: https://github.com/apache/spark/pull/23731#issuecomment-463535738
 
 
   > the fix itself looks fine to me. Just some comments on the test, may you 
please also re-run the benchmark for the query having a considerable perf issue 
earlier i order to confirm now we have no regression? Thanks.
   
   @mgaido91, I checked that the PR now doesn't add pref regression.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to