viirya commented on a change in pull request #23773: [SPARK-26721][ML] Avoid
per-tree normalization in featureImportance for GBT
URL: https://github.com/apache/spark/pull/23773#discussion_r256430111
##########
File path: mllib/src/main/scala/org/apache/spark/ml/tree/treeModels.scala
##########
@@ -147,18 +147,30 @@ private[ml] object TreeEnsembleModel {
* If -1, then numFeatures is set based on the max
feature index in all trees.
* @return Feature importance values, of length numFeatures.
*/
- def featureImportances[M <: DecisionTreeModel](trees: Array[M], numFeatures:
Int): Vector = {
Review comment:
We need to update the document of `featureImportances`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
