viirya commented on a change in pull request #23773: [SPARK-26721][ML] Avoid
per-tree normalization in featureImportance for GBT
URL: https://github.com/apache/spark/pull/23773#discussion_r257454937
##########
File path:
mllib/src/test/scala/org/apache/spark/ml/classification/GBTClassifierSuite.scala
##########
@@ -363,7 +363,8 @@ class GBTClassifierSuite extends MLTest with
DefaultReadWriteTest {
val gbtWithFeatureSubset = gbt.setFeatureSubsetStrategy("1")
val importanceFeatures = gbtWithFeatureSubset.fit(df).featureImportances
val mostIF = importanceFeatures.argmax
- assert(mostImportantFeature !== mostIF)
+ assert(mostIF === 1)
Review comment:
Yea, it is correct since there is fixed seed.
Anyway, `assert(mostIF === 1)` actually means `assert(mostImportantFeature
== mostIF)`. This assertion doesn't make much sense as the previous one
`assert(mostImportantFeature !== mostIF)`. It doesn't tell us much except that
it is happened to have the same most important feature...
OK for me to leave it as it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
