vanzin commented on a change in pull request #23599: [SPARK-24793][K8s] Enhance
spark-submit for app management
URL: https://github.com/apache/spark/pull/23599#discussion_r256535582
##########
File path: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala
##########
@@ -1346,6 +1360,21 @@ private[spark] object SparkSubmitUtils {
}
}
+ private[deploy] def getSubmitOperations(master: String):
SparkSubmitOperationsClient = {
+ val loader = Utils.getContextOrSparkClassLoader
+ val serviceLoaders =
+ ServiceLoader.load(classOf[SparkSubmitOperationsClient], loader)
+ .asScala
+ .filter(_.supports(master))
+ if (serviceLoaders.size > 1) {
+ throw new SparkException(
+ s"Multiple external SparkSubmitOperations clients registered.")
+ }
+ serviceLoaders.headOption match {
+ case Some(client) => client
+ case _ => throw new IllegalArgumentException(s"Could not parse Master
URL: '$master'")
Review comment:
The error message is wrong.
I still think mixing conditions and matching here is sub-optimal. Either use
conditions for everything, or a big match for all the different conditions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
