maropu commented on a change in pull request #23783: [SPARK-26854][SQL] Support
ANY/SOME subquery
URL: https://github.com/apache/spark/pull/23783#discussion_r256804080
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
##########
@@ -1148,6 +1165,12 @@ class AstBuilder(conf: SQLConf) extends
SqlBaseBaseVisitor[AnyRef] with Logging
EqualNullSafe(e, expression(ctx.right))
case SqlBaseParser.DISTINCT =>
Not(EqualNullSafe(e, expression(ctx.right)))
+ case SqlBaseParser.ANY | SqlBaseParser.SOME =>
+ invertIfNotDefined(AnySubquery(
+ getValueExpressions(e),
+ getComparisonOperator(
+
ctx.comparisonOperator.getChild(0).asInstanceOf[TerminalNode].getSymbol.getType),
+ ListQuery(plan(ctx.query))))
Review comment:
We cannot define an actual binary comp expr here?, e.g.,
```
case AnySubquery(cmp: BinaryComparison)
getComparison(left: Expression, right: Expression): BinaryComparison = { ...
}
AnySubquery(getComparison(left = getValueExpression(e), right =
ListQuery(plan(ctx.query))))
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
