maropu commented on a change in pull request #23783: [SPARK-26854][SQL] Support
ANY/SOME subquery
URL: https://github.com/apache/spark/pull/23783#discussion_r256801489
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
##########
@@ -145,13 +147,24 @@ case class Not(child: Expression)
override def sql: String = s"(NOT ${child.sql})"
}
+
/**
- * Evaluates to `true` if `values` are returned in `query`'s result set.
+ * An [[Expression]] compares `values` with a `query`.
+ *
+ * Note: comparison can be `NotEqualTo` which should be rewrite as
`Not(EqualTo)`.
+ *
+ * TODO: support `ALL` subquery.
*/
-case class InSubquery(values: Seq[Expression], query: ListQuery)
- extends Predicate with Unevaluable {
+abstract class SubqueryPredicate(
Review comment:
`PredicateSubquery`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
