maropu commented on a change in pull request #23750: [SPARK-19712][SQL] Pushing
Left Semi and Left Anti joins through Project, Aggregate, Window, Union etc.
URL: https://github.com/apache/spark/pull/23750#discussion_r256814201
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala
##########
@@ -267,6 +267,17 @@ object ScalarSubquery {
case _ => false
}.isDefined
}
+
+ def hasScalarSubquery(e: Expression): Boolean = {
+ e.find {
+ case s: ScalarSubquery => true
+ case _ => false
+ }.isDefined
+ }
+
+ def hasScalarSubquery(e: Seq[Expression]): Boolean = {
+ e.find(hasScalarSubquery(_)).isDefined
+ }
Review comment:
How about removing this method, and then just writing like this in
Optimizer.scala#1197?
```
if pList.forall(_.deterministic) &&
!pList.find(hasScalarSubquery(_)).isDefined &&
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
