imatiach-msft commented on a change in pull request #17084:
[SPARK-24103][ML][MLLIB] ML Evaluators should use weight column - added weight
column for binary classification evaluator
URL: https://github.com/apache/spark/pull/17084#discussion_r257114286
##########
File path:
mllib/src/main/scala/org/apache/spark/mllib/evaluation/BinaryClassificationMetrics.scala
##########
@@ -53,6 +62,15 @@ class BinaryClassificationMetrics @Since("1.3.0") (
@Since("1.0.0")
def this(scoreAndLabels: RDD[(Double, Double)]) = this(scoreAndLabels, 0)
+ /**
+ * Retrieves the score and labels (for binary compatibility).
+ * @return The score and labels.
+ */
+ @Since("1.0.0")
Review comment:
If I understand correctly, a getter is constructed in binary only if the
field is used somewhere else outside the class, and apparently it was used as a
getter. However, I can't tell where it was used from the current code, perhaps
it was used that way in the past in an earlier version of the code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
