viirya commented on a change in pull request #23802: [SPARK-26893][SQL] Allow
pushdown of partition pruning subquery filters to file source
URL: https://github.com/apache/spark/pull/23802#discussion_r257461375
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileSourceStrategy.scala
##########
@@ -170,7 +173,7 @@ object FileSourceStrategy extends Strategy with Logging {
l.resolve(fsRelation.dataSchema,
fsRelation.sparkSession.sessionState.analyzer.resolver)
// Partition keys are not available in the statistics of the files.
- val dataFilters =
normalizedFilters.filter(_.references.intersect(partitionSet).isEmpty)
+ val dataFilters =
normalizedFiltersWithoutSubqueries.filter(_.references.intersect(partitionSet).isEmpty)
Review comment:
Looks like this assumes that data filters are only used in data source
pushing down filters. But `FileIndex.listFiles` also has data filters as
parameter. `listFiles` doesn't clearly define how it will use...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
