viirya commented on a change in pull request #23802: [SPARK-26893][SQL] Allow
pushdown of partition pruning subquery filters to file source
URL: https://github.com/apache/spark/pull/23802#discussion_r257462014
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
##########
@@ -433,8 +433,14 @@ object DataSourceStrategy {
*/
protected[sql] def normalizeFilters(
filters: Seq[Expression],
- attributes: Seq[AttributeReference]): Seq[Expression] = {
- filters.filterNot(SubqueryExpression.hasSubquery).map { e =>
Review comment:
Filtering out subqueries is out of the purpose of `normalizeFilters`. It was
not good to implicitly do this. I think we can either updating method document,
or moving of filtering of subqueries as a small helper method
`filterSubqueryFilters`.
Then we can do `normalizeFilters(filters, attributes)` and
`normalizeFilters(filterSubqueryFilters(filters), attributes)`, individually.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
