peter-toth commented on a change in pull request #23802: [SPARK-26893][SQL]
Allow partition pruning with subquery filters on file source
URL: https://github.com/apache/spark/pull/23802#discussion_r257633807
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala
##########
@@ -185,6 +185,14 @@ case class FileSourceScanExec(
ret
}
+ @transient private lazy val selectedPartitionsCount =
+ if (partitionFilters.exists(f =>
+ SubqueryExpression.hasSubquery(f) ||
ExecSubqueryExpression.hasSubquery(f))) {
Review comment:
Actually `SubqueryExpression.hasSubquery(f)` is not necessary to work
correctly. But it was helpful with debugging as `FileSourceScanExec.toString`
refers to `metadata` and so throws an exception when `SubqueryExpression`
hasn't been transformed to `ExecSubqueryExpression`. But I can remove it if
having it there is confusing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
