peter-toth commented on a change in pull request #23802: [SPARK-26893][SQL] 
Allow partition pruning with subquery filters on file source
URL: https://github.com/apache/spark/pull/23802#discussion_r257682216
 
 

 ##########
 File path: 
sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala
 ##########
 @@ -185,6 +185,13 @@ case class FileSourceScanExec(
     ret
   }
 
+  @transient private lazy val selectedPartitionsCount =
+    if (partitionFilters.exists(ExecSubqueryExpression.hasSubquery)) {
+      None
 
 Review comment:
   This is invoked from `FileSourceScanExec.metadata` and part of 
`FileSourceScanExec`'s `toString` value too, so it would throw 
   ```
   requirement failed: Subquery subquery250 has not finished
   java.lang.IllegalArgumentException: requirement failed: Subquery subquery250 
has not finished
        at scala.Predef$.require(Predef.scala:281)
        at org.apache.spark.sql.execution.ScalarSubquery.eval(subquery.scala:95)
   ```
   exception when printing executed plan.
   And I didn't want to get rid of `PartitionCount` metadata entirely.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to