srowen commented on a change in pull request #23845: [SPARK-26941][YARN]Fix
incorrect computation of maxNumExecutorFailures in ApplicationMaster for
streaming
URL: https://github.com/apache/spark/pull/23845#discussion_r258510167
##########
File path:
streaming/src/main/scala/org/apache/spark/streaming/scheduler/ExecutorAllocationManager.scala
##########
@@ -152,32 +150,35 @@ private[streaming] class ExecutorAllocationManager(
private def validateSettings(): Unit = {
require(
scalingIntervalSecs > 0,
- s"Config $SCALING_INTERVAL_KEY must be more than 0")
+ s"Config ${STREAMING_DYN_ALLOCATION_SCALING_INTERVAL.key} must be more
than 0")
Review comment:
Can we move these simple checks for a positive value to the new config
objects you add here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
