srowen commented on a change in pull request #23845: [SPARK-26941][YARN]Fix
incorrect computation of maxNumExecutorFailures in ApplicationMaster for
streaming
URL: https://github.com/apache/spark/pull/23845#discussion_r258511724
##########
File path: core/src/main/scala/org/apache/spark/internal/config/package.scala
##########
@@ -332,6 +332,34 @@ package object config {
ConfigBuilder("spark.dynamicAllocation.sustainedSchedulerBacklogTimeout")
.fallbackConf(DYN_ALLOCATION_SCHEDULER_BACKLOG_TIMEOUT)
+ private[streaming] val STREAMING_DYN_ALLOCATION_ENABLED =
Review comment:
It's good to refactor the streaming configs into config objects like this.
However I think these should do into a new `.../streaming/config/package.scala`
file. Right now I'm not sure how it would interpret `private[streaming]` from
here.
Really, this is most of the change here. It's OK to do in one place, but I'd
open a new JIRA as a subtask of
https://issues.apache.org/jira/browse/SPARK-26442 for streaming (can't believe
we missed that!) and also add that new JIRA to the title.
There may be more. You could also fix additional `spark.streaming.` configs
separately.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
