cloud-fan commented on a change in pull request #23259: [SPARK-26215][SQL]
Define reserved/non-reserved keywords based on the ANSI SQL standard
URL: https://github.com/apache/spark/pull/23259#discussion_r259229434
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
##########
@@ -1404,6 +1404,15 @@ class AstBuilder(conf: SQLConf) extends
SqlBaseBaseVisitor[AnyRef] with Logging
}
}
+ override def visitIdentifier(ctx: IdentifierContext): String =
withOrigin(ctx) {
+ val keyword = ctx.getText
+ if (ctx.ansiReserved() != null) {
+ throw new ParseException(
+ s"'$keyword' is reserved and you cannot use this keyword as an
identifier.", ctx)
Review comment:
hmmm, do we need to do it in this PR? I think this PR just changes the list
of non-reserved/reserved keywords according to the config.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
