cloud-fan commented on a change in pull request #23259: [SPARK-26215][SQL]
Define reserved/non-reserved keywords based on the ANSI SQL standard
URL: https://github.com/apache/spark/pull/23259#discussion_r259230214
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/TableIdentifierParserSuite.scala
##########
@@ -53,10 +55,96 @@ class TableIdentifierParserSuite extends SparkFunSuite {
"bigint", "binary", "boolean", "current_date", "current_timestamp",
"date", "double", "float",
"int", "smallint", "timestamp", "at", "position", "both", "leading",
"trailing", "extract")
- val hiveStrictNonReservedKeyword = Seq("anti", "full", "inner", "left",
"semi", "right",
+ val hiveStrictNonReservedKeywords = Seq("anti", "full", "inner", "left",
"semi", "right",
Review comment:
hmm, seems we don't have reserved keywords at all before this PR. We only
have non-reserved keywords and strict-non-reserved keywords...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
