cloud-fan commented on a change in pull request #23750: [SPARK-19712][SQL] Pushing Left Semi and Left Anti joins through Project, Aggregate, Window, Union etc. URL: https://github.com/apache/spark/pull/23750#discussion_r259342739
########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/PushDownLeftSemiAntiJoin.scala ########## @@ -0,0 +1,203 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.catalyst.optimizer + +import org.apache.spark.sql.catalyst.expressions._ +import org.apache.spark.sql.catalyst.plans._ +import org.apache.spark.sql.catalyst.plans.logical._ +import org.apache.spark.sql.catalyst.rules.Rule + +/** + * This rule is a variant of [[PushDownPredicate]] which can handle + * pushing down Left semi and Left Anti joins below the following operators. + * 1) Project + * 2) Window + * 3) Union + * 4) Aggregate + * 5) Other permissible unary operators. please see [[PushDownPredicate.canPushThrough]]. + */ +object PushDownLeftSemiAntiJoin extends Rule[LogicalPlan] with PredicateHelper { + def apply(plan: LogicalPlan): LogicalPlan = plan transform { + // LeftSemi/LeftAnti over Project + case Join(p @ Project(pList, gChild), rightOp, LeftSemiOrAnti(joinType), joinCond, hint) + if pList.forall(_.deterministic) && !pList.exists(ScalarSubquery.hasScalarSubquery) && Review comment: Continue the discussion. After some more thoughts, I'm wondering why the `PushDownPredicate` doesn't care about scalar subquery at all. The thing I'm worried about is, currently correlated subquery filter is pushed down in the rule `PushDownPredicate` and then converted to left semi/anti joins. After your refactor, correlated subquery filter will be converted to left semi/anti join first, then be pushed down with this rule. If this rule can't behave exactly the same with `PushDownPredicate`, we may have perf regression. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
