HeartSaVioR commented on a change in pull request #23908: [SPARK-27001][SQL]
Refactor "serializerFor" method between ScalaReflection and JavaTypeInference
URL: https://github.com/apache/spark/pull/23908#discussion_r261038518
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/DeserializerBuildHelper.scala
##########
@@ -48,8 +48,8 @@ object DeserializerBuildHelper {
expr: Expression,
dataType: DataType,
nullable: Boolean,
- walkedTypePath: Seq[String],
- funcForCreatingNewExpr: (Expression, Seq[String]) => Expression):
Expression = {
+ walkedTypePath: WalkedTypePath,
+ funcForCreatingNewExpr: (Expression, WalkedTypePath) => Expression):
Expression = {
val newExpr = funcForCreatingNewExpr(expr, walkedTypePath)
Review comment:
Yeah I might thought too complicated. Not a big deal and looks simpler. Will
address. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
