HeartSaVioR commented on a change in pull request #23908: [SPARK-27001][SQL]
Refactor "serializerFor" method between ScalaReflection and JavaTypeInference
URL: https://github.com/apache/spark/pull/23908#discussion_r261058210
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/DeserializerBuildHelper.scala
##########
@@ -39,40 +39,38 @@ object DeserializerBuildHelper {
path: Expression,
ordinal: Int,
dataType: DataType,
- walkedTypePath: Seq[String]): Expression = {
+ walkedTypePath: WalkedTypePath): Expression = {
val newPath = GetStructField(path, ordinal)
upCastToExpectedType(newPath, dataType, walkedTypePath)
}
def deserializerForWithNullSafety(
Review comment:
I think `expressionWithNullSafety` is more general naming so might be
preferred one, but `deserializerForWithNullSafety` is also a good name cause we
have relevant method `deserializerForWithNullSafetyAndUpcast`.
So that's a matter of preference and either can be removed. Which method
would we prefer to keep?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
