arunmahadevan commented on a change in pull request #23912: [SPARK-21029][SS]
StreamingQuery should be stopped when the SparkSession is stopped
URL: https://github.com/apache/spark/pull/23912#discussion_r261442792
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala
##########
@@ -723,6 +725,11 @@ class SparkSession private(
* @since 2.0.0
*/
def stop(): Unit = {
+ if (!stopped.compareAndSet(false, true)) {
+ logInfo("SparkSession already stopped.")
Review comment:
To avoid it I would need to introduce a new hook method that `SparkSession`
registers with `SparkContext` which is invoked when `SparkContext.stop` is
invoked. I think that would also handle a few corner cases. Can I explore that
option?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
