arunmahadevan commented on a change in pull request #23912: [SPARK-21029][SS]
StreamingQuery should be stopped when the SparkSession is stopped
URL: https://github.com/apache/spark/pull/23912#discussion_r261733946
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala
##########
@@ -742,6 +749,22 @@ class SparkSession private(
DataType.fromJson(dataTypeString)
}
+ /**
+ * Stops all active streaming queries
+ */
+ private def stopStreamingQueries(): Unit = {
Review comment:
@dongjoon-hyun , moving this to `StreamingQueryManager` fails in some cases.
E.g. if the Spark context was already stopped, the SparkSession still tries to
lazily load the `streams` (StreamingQueryManager) to invoke the method and the
lazy initialization fails.
So I have moved the method back into `SparkSession`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
