wypoon commented on a change in pull request #23767: [SPARK-26329][CORE][WIP]
Faster polling of executor memory metrics.
URL: https://github.com/apache/spark/pull/23767#discussion_r261923733
##########
File path:
core/src/test/scala/org/apache/spark/scheduler/ReplayListenerSuite.scala
##########
@@ -218,9 +218,7 @@ class ReplayListenerSuite extends SparkFunSuite with
BeforeAndAfter with LocalSp
// Verify the same events are replayed in the same order
assert(sc.eventLogger.isDefined)
- val originalEvents = sc.eventLogger.get.loggedEvents.filter { e =>
-
!JsonProtocol.sparkEventFromJson(e).isInstanceOf[SparkListenerStageExecutorMetrics]
- }
+ val originalEvents = sc.eventLogger.get.loggedEvents
Review comment:
My change simply reverts originalEvents to what it had been before @edwinalu
changed it. In ReplayListenerSuite, "End-to-end replay" and "End-to-end replay
with compression" were failing with the filter, and removing the filter made
them pass. It seems that SparkListenerStageExecutorMetrics events now show up
in replayedEvents with my changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
