vanzin commented on a change in pull request #23939: [SPARK-27019]
[webUI]onJobStart happens after onExecutionEnd shouldn't overwrite kvstore
URL: https://github.com/apache/spark/pull/23939#discussion_r262207586
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/ui/SQLAppStatusListenerSuite.scala
##########
@@ -384,6 +384,35 @@ class SQLAppStatusListenerSuite extends SparkFunSuite
with SharedSQLContext with
assertJobs(statusStore.execution(executionId), failed = Seq(0))
}
+ test("onJobStart happens after onExecutionEnd shouldn't overwrite kvstore") {
+ val statusStore = createStatusStore()
+ val listener = statusStore.listener.get
+
+ val executionId = 0
+ val df = createTestDataFrame
+ listener.onOtherEvent(SparkListenerSQLExecutionStart(
+ executionId,
+ "test",
+ "test",
+ df.queryExecution.toString,
+ SparkPlanInfo.fromSparkPlan(df.queryExecution.executedPlan),
+ System.currentTimeMillis()))
+ listener.onOtherEvent(SparkListenerSQLExecutionEnd(
+ executionId, System.currentTimeMillis()))
+ listener.onJobStart(SparkListenerJobStart(
+ jobId = 0,
+ time = System.currentTimeMillis(),
+ stageInfos = Seq.empty,
+ createProperties(executionId)))
+ listener.onJobEnd(SparkListenerJobEnd(
+ jobId = 0,
+ time = System.currentTimeMillis(),
+ JobFailed(new RuntimeException("Oops"))
+ ))
+
Review comment:
add `assert(listener.noLiveData())`? To make sure the live data is being
cleaned up properly in this case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
