Github user JoshRosen commented on the pull request:

    https://github.com/apache/spark/pull/3647#issuecomment-67235372
  
    This is a good catch, since it looks like the original intent was that we'd 
remove `receiverInfo` entries since there's a `receiverInfo.isEmpty` check.
    
    In fact, a much older version of this code actually had the remove call:
    
https://github.com/apache/spark/blob/61c001676a0e098a0bbefca838df91dfd2375b03/streaming/src/main/scala/org/apache/spark/streaming/scheduler/NetworkInputTracker.scala#L97
    
    That file got renamed, but the `remove` call was preserved: 
https://github.com/apache/spark/blob/04c37b6f749dc2418cc28c89964cdc687dfcbd51/streaming/src/main/scala/org/apache/spark/streaming/scheduler/ReceiverTracker.scala#L141
    
    It looks like the bug was actually introduced in #540, possibly as a 
copy-paste error when copying repeated code between `reportError` and 
`deregisterReceiver`: 
https://github.com/apache/spark/commit/cd12dd9bde91303d0341180e5f70d2a03d6b65b6#diff-5241413c0679331ccda4cf2063b4ea0fL141


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to