Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/3647#discussion_r21933656
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/scheduler/ReceiverTracker.scala
---
@@ -152,6 +152,7 @@ class ReceiverTracker(ssc: StreamingContext,
skipReceiverLaunch: Boolean = false
}
receiverInfo(streamId) = newReceiverInfo
--- End diff --
It seems a little suspicious to me that we assign to `receiverInfo` on this
line only to remove the value that we set two lines later. I think it would be
clearer to remove this line and change the next line to read
```scala
listenerBus.post(StreamingListenerReceiverStopped(newReceiverInfo))
```
instead.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
