Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/3638#discussion_r21938291
--- Diff: core/src/test/scala/org/apache/spark/SharedSparkContext.scala ---
@@ -30,7 +30,7 @@ trait SharedSparkContext extends BeforeAndAfterAll {
self: Suite =>
var conf = new SparkConf(false)
override def beforeAll() {
- _sc = new SparkContext("local", "test", conf)
+ _sc = new SparkContext("local[4]", "test", conf)
--- End diff --
Looks like I left out the comment I originally had there...
I wanted to force serialization to occur between threads. Is this not
necessary? We explicitly use multiple threads in our unit tests to reproduce
issues like this in our own unit tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
