Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/3431#discussion_r21940231
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/sources/FilteredScanSuite.scala ---
@@ -24,18 +24,26 @@ import org.apache.spark.sql._
class FilteredScanSource extends RelationProvider {
override def createRelation(
sqlContext: SQLContext,
- parameters: Map[String, String]): BaseRelation = {
- SimpleFilteredScan(parameters("from").toInt,
parameters("to").toInt)(sqlContext)
+ parameters: Map[String, String],
--- End diff --
I'm not really sure if we need to rewrite all of these test cases since the
only code path that is changing here is `DDLParser -> RelationProvider`. The
planner is exactly the same. I'd just add one new test case that makes sure
that schemas are passed correctly when using the new synatx. Also there needs
to be better coverage for the various datatypes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
