gagafunctor commented on a change in pull request #23983: [SPARK-26881][core]
Heuristic for tree aggregate depth
URL: https://github.com/apache/spark/pull/23983#discussion_r263843782
##########
File path:
mllib/src/test/scala/org/apache/spark/mllib/linalg/distributed/RowMatrixSuite.scala
##########
@@ -101,6 +101,17 @@ class RowMatrixSuite extends SparkFunSuite with
MLlibTestSparkContext {
}
}
+ test("getTreeAggregateIdealDepth") {
+ val nbPartitions = 10000
+ val vectors = sc.emptyRDD[Vector]
+ .repartition(nbPartitions)
+ vectors.conf.set("spark.driver.maxResultSize", "10g")
Review comment:
So about this line: I figured out that changing this will affect the
sparkConf for tests that will be executed after this one aswell (I tried to set
maxResultSize to 10bytes here and it broke several later tests).
Do you knowwhat's the disired way to make this only change the sparkConf for
the closure of this test ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
