srowen commented on a change in pull request #23983: [SPARK-26881][mllib]
Heuristic for tree aggregate depth
URL: https://github.com/apache/spark/pull/23983#discussion_r263889188
##########
File path:
mllib/src/test/scala/org/apache/spark/mllib/linalg/distributed/RowMatrixSuite.scala
##########
@@ -101,6 +101,17 @@ class RowMatrixSuite extends SparkFunSuite with
MLlibTestSparkContext {
}
}
+ test("getTreeAggregateIdealDepth") {
+ val nbPartitions = 10000
+ val vectors = sc.emptyRDD[Vector]
+ .repartition(nbPartitions)
+ vectors.conf.set("spark.driver.maxResultSize", "10g")
Review comment:
Do you have to change this from 2g for it to select a depth of 3? does a
little larger number of partitions help? I thought you might have to reduce it
if anything. There are ways to isolate the conf change to just the test, but if
it's avoidable that's better
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
