srowen commented on issue #24030: [SPARK-27109][SQL] Refactoring of TimestampFormatter and DateFormatter URL: https://github.com/apache/spark/pull/24030#issuecomment-471191102 It seems OK, but do you need to break these out into a method plus two private helpers? it's OK by me, just adds some indirection, but no big deal
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
