srowen commented on issue #24030: [SPARK-27109][SQL] Refactoring of TimestampFormatter and DateFormatter URL: https://github.com/apache/spark/pull/24030#issuecomment-471195248 OK, it's fine if you think it might make a difference to performance. I always weigh that against the readability of jumping across two methods to understand what is happening, but they're all together, and I suppose it makes the steps a little clearer.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
