Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/3643#issuecomment-67447322
Yes. The additional tests are used to test these bugs we found in this PR.
For example, `fastSquaredDistance(v2, norm2, v4, norm4, precision)` is used to
test the case where two `SparseVector`s have different indices which is the
major bug you mentioned.
Original test only contains the cases of `SparseVector` vs. `DenseVector`
and `DenseVector` vs. `DenseVector`. The additional test includes comprehensive
tests for different combinations.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]