Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/3721#discussion_r22027430
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/util/WriteAheadLogManager.scala
---
@@ -125,7 +125,7 @@ private[streaming] class WriteAheadLogManager(
* between the node calculating the threshTime (say, driver node), and
the local system time
* (say, worker node), the caller has to take account of possible time
skew.
*/
- def cleanupOldLogs(threshTime: Long): Unit = {
+ def cleanupOldLogs(threshTime: Long): Future[Unit] = {
--- End diff --
IMO, I prefer to also return `Future` for an asynchronous action. Returning
`Unit` hides the asynchronous feature and such method will be misused easily.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
