shahidki31 commented on a change in pull request #24079:
[SPARK-27145][Minor]Close store in the SQLAppStatusListenerSuite after test
URL: https://github.com/apache/spark/pull/24079#discussion_r265170087
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/ui/SQLAppStatusListenerSuite.scala
##########
@@ -589,6 +602,7 @@ class SQLAppStatusListenerSuite extends SparkFunSuite with
SharedSQLContext with
time))
assert(statusStore.executionsCount === 2)
assert(statusStore.execution(2) === None)
+ store.close()
Review comment:
Hi @attilapiros , Thanks for the comment. I combined the both kvstore and it
will create in the before block.
"retainedExecution" configuration is needed for only the "listener". Similar
test is there in the "AppStatusListenerSuite", where store doesn't use listener
specific conf.
https://github.com/apache/spark/blob/d3813d8b210d127ea278015ef27ead9348365787/core/src/test/scala/org/apache/spark/status/AppStatusListenerSuite.scala#L1297-L1303
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
