shahidki31 commented on a change in pull request #24079:
[SPARK-27145][Minor]Close store in the SQLAppStatusListenerSuite after test
URL: https://github.com/apache/spark/pull/24079#discussion_r265621464
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/ui/AllExecutionsPageSuite.scala
##########
@@ -32,10 +33,20 @@ import org.apache.spark.sql.test.SharedSQLContext
import org.apache.spark.status.ElementTrackingStore
import org.apache.spark.util.kvstore.InMemoryStore
-class AllExecutionsPageSuite extends SharedSQLContext {
+class AllExecutionsPageSuite extends SharedSQLContext with BeforeAndAfter {
import testImplicits._
+ var kvstore: ElementTrackingStore = _
+
+ before {
+ kvstore = new ElementTrackingStore(new InMemoryStore, sparkContext.conf)
Review comment:
Yes. We can create the kvstore inside 'createStatusStore' method. In future,
if any test cases doesn't required kvstore, we don't need create store. I will
update.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
