dongjoon-hyun commented on a change in pull request #24047: [SPARK-25196][SQL]
Extends Analyze commands for cached tables
URL: https://github.com/apache/spark/pull/24047#discussion_r265842545
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/StatisticsCollectionSuite.scala
##########
@@ -470,4 +471,34 @@ class StatisticsCollectionSuite extends
StatisticsCollectionTestBase with Shared
}
}
}
+
+ test("analyzes column statistics in cached query") {
+ withTempView("cachedTempView", "tempView") {
+ spark.sql(
+ """CACHE TABLE cachedTempView AS
Review comment:
Maybe, `cachedQuery` is better than `cachedTempView`?
For me, `cachedTempView` sounds like the following.
```sql
CREATE TEMPORARY VIEW tempView AS ...
CACHE TABLE tempView
```
We can rename this from `cachedTempView` to `cachedQuery` first. Then, we
can add a new test case for the real cached temp views of the above SQL case
before line 496.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
