dongjoon-hyun commented on a change in pull request #24047: [SPARK-25196][SQL]
Extends Analyze commands for cached tables
URL: https://github.com/apache/spark/pull/24047#discussion_r266276645
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/CacheManager.scala
##########
@@ -154,6 +155,22 @@ class CacheManager extends Logging {
}
}
+ // Analyzes column statistics in the given cache data
+ private[sql] def analyzeColumnCacheQuery(
+ sparkSession: SparkSession,
+ cachedData: CachedData,
+ column: Seq[Attribute]): Unit = {
Review comment:
@maropu . Recently, https://github.com/apache/spark/pull/24028 changed
`cachedData` as an immutable sequence and this is guarded by `this` for all
WRITE operations. This is a write operation, isn't it?
cc @cloud-fan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
