jose-torres commented on a change in pull request #23749: [SPARK-26841][SQL]
Kafka timestamp pushdown
URL: https://github.com/apache/spark/pull/23749#discussion_r266095176
##########
File path:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaOffsetReader.scala
##########
@@ -396,6 +406,8 @@ private[kafka010] class KafkaOffsetReader(
}
private[kafka010] object KafkaOffsetReader {
+ // offsets are not instances of Optional, we need special state for None
+ val EMPTY_OFFSET: Long = -100L
Review comment:
I'm not sure I follow why this is needed. Normally, if fetchOffsetsByTime
sometimes needs to return offsets and sometimes needs to return None, it should
just return Option[Offset] values.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
