rdblue commented on a change in pull request #23848: [SPARK-26946][SQL]
Identifiers for multi-catalog
URL: https://github.com/apache/spark/pull/23848#discussion_r266181091
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/identifiers.scala
##########
@@ -105,3 +105,15 @@ case class FunctionIdentifier(funcName: String, database:
Option[String])
object FunctionIdentifier {
def apply(funcName: String): FunctionIdentifier = new
FunctionIdentifier(funcName)
}
+
+/**
+ * Catalog identifier.
+
+ * @param space Namespace in the catalog
+ * @param name Object name
+ */
+case class CatalogIdentifier(space: CatalogIdentifier.Namespace, name: String)
Review comment:
Looks like `Identifier` isn't used. If this is in the v2 namespace, it would
be fine to simply call the interface `Identifier`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
