rdblue commented on a change in pull request #23848: [SPARK-26946][SQL]
Identifiers for multi-catalog
URL: https://github.com/apache/spark/pull/23848#discussion_r266181166
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/identifiers.scala
##########
@@ -105,3 +105,15 @@ case class FunctionIdentifier(funcName: String, database:
Option[String])
object FunctionIdentifier {
def apply(funcName: String): FunctionIdentifier = new
FunctionIdentifier(funcName)
}
+
+/**
+ * Catalog identifier.
+
+ * @param space Namespace in the catalog
+ * @param name Object name
+ */
+case class CatalogIdentifier(space: CatalogIdentifier.Namespace, name: String)
Review comment:
I think that these should be in the
`org.apache.spark.sql.catalyst.catalog.v2` namespace. That separates the new
identifiers from the old ones and keeps them with the other v2 additions.
Also, we will need to translate this to Java. I wrote the SPIP using scala
conventions for clarity, but we should use types that are Java-friendly. For
example, Java implementations should not be passed `Seq` so namespace should be
`Array[String]` instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
