HyukjinKwon commented on a change in pull request #23882: [SPARK-26979][PYTHON]
Add missing string column name support for some SQL functions
URL: https://github.com/apache/spark/pull/23882#discussion_r266336008
##########
File path: python/pyspark/sql/functions.py
##########
@@ -1437,10 +1453,6 @@ def hash(*cols):
'ascii': 'Computes the numeric value of the first character of the string
column.',
'base64': 'Computes the BASE64 encoding of a binary column and returns it
as a string column.',
'unbase64': 'Decodes a BASE64 encoded string column and returns it as a
binary column.',
- 'initcap': 'Returns a new string column by converting the first letter of
each word to ' +
- 'uppercase. Words are delimited by whitespace.',
- 'lower': 'Converts a string column to lower case.',
- 'upper': 'Converts a string column to upper case.',
Review comment:
I was saying `lower` and `upper`. Looks it has been overwritten by this, so
if we keep here, it keeps previous definition. Did you check which PR and JIRAs
added `lower` and `upper`?
Also, strictly this should have not been removed in this PR as it doesn't
target to remove overwritten functions. As you said, we should avoid such
function definition way later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
