HyukjinKwon commented on a change in pull request #23882: [SPARK-26979][PYTHON]
Add missing string column name support for some SQL functions
URL: https://github.com/apache/spark/pull/23882#discussion_r266336898
##########
File path: python/pyspark/sql/functions.py
##########
@@ -85,13 +96,16 @@ def _():
>>> df.select(lit(5).alias('height')).withColumn('spark_user',
lit(True)).take(1)
[Row(height=5, spark_user=True)]
"""
-_functions = {
+_name_functions = {
+ # name functions take a column name as their argument
'lit': _lit_doc,
Review comment:
One (lit) of five (col, column, asc, desc, lit) doesn't sound like a special
case tho. It had to have a better category if 20% of items doesn't fit to the
category.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
